-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add ecs jit sdk #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add ecs jit sdk #1103
Conversation
| folder_key: Optional[str] = None, | ||
| folder_path: Optional[str] = None, | ||
| ) -> Any: | ||
| def retrieve_by_id(self, id: str) -> Any: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we keep the folder params?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this ecs api doesn't require/use folder params for anything. So updating the sdk to match
d308f56 to
aca152a
Compare
src/uipath/platform/context_grounding/_context_grounding_service.py
Outdated
Show resolved
Hide resolved
src/uipath/platform/context_grounding/_context_grounding_service.py
Outdated
Show resolved
Hide resolved
| ) | ||
|
|
||
| @field_serializer("last_ingested", "last_queried", when_used="json") | ||
| @field_serializer("last_ingested", "last_queried") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it can serialize for the waitephemeralindex interrupt
radu-mocanu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
let s fix the tests
| """ | ||
| spec = self._retrieve_by_id_spec( | ||
| id, | ||
| folder_key=folder_key, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not still required for folder based indexes? (Not ephemeral)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b5b4d96 to
82f1256
Compare
11cdc3b to
9bbe332
Compare


No description provided.