Skip to content

Conversation

@CalebMartinUiPath
Copy link

No description provided.

@github-actions github-actions bot added test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository labels Jan 14, 2026
folder_key: Optional[str] = None,
folder_path: Optional[str] = None,
) -> Any:
def retrieve_by_id(self, id: str) -> Any:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we keep the folder params?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ecs api doesn't require/use folder params for anything. So updating the sdk to match

@CalebMartinUiPath CalebMartinUiPath force-pushed the caleb/jit-ecs-sdk branch 2 times, most recently from d308f56 to aca152a Compare January 19, 2026 20:54
)

@field_serializer("last_ingested", "last_queried", when_used="json")
@field_serializer("last_ingested", "last_queried")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it can serialize for the waitephemeralindex interrupt

Copy link
Contributor

@radu-mocanu radu-mocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

let s fix the tests

"""
spec = self._retrieve_by_id_spec(
id,
folder_key=folder_key,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not still required for folder based indexes? (Not ephemeral)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so. Not sure if this is intended:
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with user token
Screenshot 2026-01-23 at 9 26 05 AM

@CalebMartinUiPath CalebMartinUiPath marked this pull request as ready for review January 23, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants