Skip to content

chore(docs): JSDoc completeness validation check#592

Open
Raina451 wants to merge 4 commits into
mainfrom
chore/jsdoc-completeness-validation
Open

chore(docs): JSDoc completeness validation check#592
Raina451 wants to merge 4 commits into
mainfrom
chore/jsdoc-completeness-validation

Conversation

@Raina451

@Raina451 Raina451 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Adds a JSDoc completeness gate using TypeDoc's built-in notDocumented validation — no custom parsing, reuses the TypeDoc dependency already in the pipeline.

It flags:

  • Public methods with no JSDoc (CallSignature)
  • Parameters with a missing or empty @param
  • @param tags whose name doesn't match a parameter

Why this approach

Evaluated eslint-plugin-jsdoc, @microsoft/api-extractor, and a hand-rolled TS-compiler-API checker. TypeDoc wins: already installed, already runs on src/index.ts — a config file + one script line instead of a new toolchain or bespoke logic.

Expected to fail initially

fix exisitng gaps in this pr: #593

Adds a `docs:validate` script that runs TypeDoc's built-in notDocumented
validation over the public API (Method, CallSignature, Parameter). Surfaces
undocumented methods, missing/empty @param tags, and @param name mismatches
without any custom parsing.

Report-only for now (no treatValidationWarningsAsErrors) so it does not fail
CI while existing gaps are cleaned up in follow-up work.

Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@claude

claude Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

✅ No issues found. Checked for bugs and CLAUDE.md compliance.

Flip typedoc.validation.json to treatValidationWarningsAsErrors and add a
jsdoc-validation job to the PR Checks workflow. Expected to fail until the
existing undocumented methods/parameters are documented or tagged @internal.

Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
Comment thread typedoc.validation.json
@Raina451
Raina451 marked this pull request as ready for review July 10, 2026 07:55
@Raina451
Raina451 requested a review from a team July 10, 2026 07:55
@Raina451 Raina451 changed the title chore(docs): add report-only JSDoc completeness validation chore(docs): JSDoc completeness validation check Jul 10, 2026
Comment thread .github/workflows/pr-checks.yml Outdated
@claude

claude Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

✅ No issues found. Checked for bugs and CLAUDE.md compliance.

Addresses review feedback — pins actions/checkout and actions/setup-node
to full commit SHAs (with version comments) instead of floating @v4 tags,
across both the new jsdoc-validation job and the existing jobs in the file.

Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@claude

claude Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

✅ No issues found. Checked for bugs and CLAUDE.md compliance.

- Add missing @param/@returns to error type guards and getErrorDetails
- Add JSDoc to createAgentWithMethods; fix stale @param name on
  createEntityWithMethods
- Document QueueServiceModel.getById options param (model + service) and
  drop the unknown @Signature tag from getAll
- Document ConversationSessionMethods params and the UiPath constructor
- Mark internal telemetry exports and error-class constructors @internal

Clears all notDocumented findings; npm run docs:validate exits 0.

Generated with Claude Code

Co-authored-by: Claude <noreply@anthropic.com>
@claude

claude Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

✅ No issues found. Checked for bugs and CLAUDE.md compliance.

@sonarqubecloud

Copy link
Copy Markdown

@Raina451
Raina451 requested a review from vnaren23 July 13, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants