-
Notifications
You must be signed in to change notification settings - Fork 12
chore(samples): fix sample-app convention gaps #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
906dc21
chore(samples): add missing config files to action & misc apps
Raina451 a21512d
chore(samples): migrate web apps to the coded-apps-dev harness
Raina451 2388b78
chore(samples): remove dead config left by the harness migration
Raina451 af6574c
docs(samples): add data-fabric-app preview demo
Raina451 24525ea
docs(samples): add preview demos for process and conversational apps
Raina451 7b664f4
chore(samples): stop gitignoring uipath.json in migrated apps
Raina451 874a28a
refactor(samples): source Data Fabric link from SDK config, not env
Raina451 aa36e4c
docs(samples): add document-validation-app preview demo
Raina451 bd68534
chore(samples): use the updated favicon across all sample apps
Raina451 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
samples/coded-action-apps/action-app-with-data-fabric-entity/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
|
|
||
| # Build outputs | ||
| node_modules | ||
| dist | ||
| dist-ssr | ||
| .uipath | ||
|
|
||
| # OS / editor | ||
| .DS_Store | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 0 additions & 30 deletions
30
samples/coded-action-apps/action-app-with-data-fabric-entity/package-lock.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Binary file added
BIN
+1.47 KB
...les/coded-action-apps/action-app-with-data-fabric-entity/src/assets/favicon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions
8
samples/coded-action-apps/action-app-with-data-fabric-entity/uipath.json.example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "clientId": "<your-oauth-external-app-client-id>", | ||
| "scope": "DataFabric.Schema.Read DataFabric.Data.Read DataFabric.Data.Write", | ||
| "orgName": "<your-org-name>", | ||
| "tenantName": "<your-tenant-name>", | ||
| "baseUrl": "https://api.uipath.com", | ||
| "redirectUri": "http://localhost:5173" | ||
| } |
21 changes: 21 additions & 0 deletions
21
samples/coded-action-apps/action-app-with-document/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
|
|
||
| # Build outputs | ||
| node_modules | ||
| dist | ||
| dist-ssr | ||
| .uipath | ||
|
|
||
| # OS / editor | ||
| .DS_Store | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 0 additions & 30 deletions
30
samples/coded-action-apps/action-app-with-document/package-lock.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Binary file added
BIN
+1.47 KB
samples/coded-action-apps/action-app-with-document/src/assets/favicon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions
8
samples/coded-action-apps/action-app-with-document/uipath.json.example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "clientId": "<your-oauth-external-app-client-id>", | ||
| "scope": "OR.Execution OR.Tasks OR.Folders", | ||
| "orgName": "<your-org-name>", | ||
| "tenantName": "<your-tenant-name>", | ||
| "baseUrl": "https://api.uipath.com", | ||
| "redirectUri": "http://localhost:5173" | ||
| } |
21 changes: 21 additions & 0 deletions
21
samples/coded-action-apps/action-app-with-file-attachment-document/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
|
|
||
| # Build outputs | ||
| node_modules | ||
| dist | ||
| dist-ssr | ||
| .uipath | ||
|
|
||
| # OS / editor | ||
| .DS_Store | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The six new
.gitignorefiles in this PR (action-app-with-document,action-app-with-image,action-app-with-file-attachment-document,action-app-with-data-fabric-entity,action-app-with-storage-bucket-document, andconversational-agent-app) are all missinguipath.jsonas an ignored pattern.data-fabric-app-angular/.gitignorealready has this entry — these should match. Without the entry:uipath.json.example→uipath.jsonand fill in real credentials will see the file as untracked (not ignored), making an accidentalgit add .easy.uipath.jsontracked (see the open thread onaction-app-with-data-fabric-entity/.gitignore), runninggit rm --cachedwould untrack them but they'd immediately show back as untracked — not ignored — because there's no.gitignoreentry.Same one-liner fix across all six files: