Skip to content

docs: update Claude docs from PR review analysis#601

Merged
ninja-shreyash merged 1 commit into
mainfrom
claude-docs-update/2026-07-13
Jul 13, 2026
Merged

docs: update Claude docs from PR review analysis#601
ninja-shreyash merged 1 commit into
mainfrom
claude-docs-update/2026-07-13

Conversation

@claude

@claude claude Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Weekly analysis of PR comments (2026-07-06 → 2026-07-13).
Analyzed 14 PRs with meaningful review threads. Found 2 actionable insights.

Changes

agent_docs/rules.md

  • New integration test rule: when a new parameter is added to an existing method, the integration test must be updated to exercise that parameter.
    Source: PR feat: add multi-join support to Data Fabric entity queries #543 — reviewer noted a passing integration test that never sends the joins parameter does not validate that the API actually accepts it. PR author added a dedicated integration test case for joins.

agent_docs/conventions.md

  • Extended the optional-field rule to cover input types (structured request/join types): fields that are structurally required for the server to execute an operation must be typed as required, not ?. Fields may only be optional when the server provides a meaningful default.
    Source: PR feat: add multi-join support to Data Fabric entity queries #543 — reviewer ninja-shreyash flagged EntityJoin fields as incorrectly all-optional; resolution made 3 key fields (joinFieldName, relatedEntityName, relatedFieldName) required while leaving entityName and joinType optional with server defaults.

No changes

  • CLAUDE.md — no relevant insights found
  • Agents.md — no relevant insights found
  • agent_docs/architecture.md — no relevant insights found

PRs Analyzed

PR Title Comments
#593 fix(docs): fill JSDoc gaps flagged by validation gate 0 meaningful threads
#600 chore: bump version to 1.5.4
#596 fix(data-fabric): make FILE fields creatable end-to-end 0 meaningful threads
#589 chore: release 1.5.3
#584 feat(cases): add sendMessage to CaseInstances for stage selection and ad-hoc task triggers 1 thread (one-off coupling concern, not generalizable)
#588 chore: bump version to 1.5.2
#559 docs: update Claude docs from PR review analysis
#583 feat(samples): add Agent Runtime Compliance dashboard sample 4 threads (sample-specific, not generalizable)
#576 feat(samples): add Angular data fabric sample app 2 threads (sample bug fix, not generalizable)
#581 docs: mark agent-memory as preview, restructure agents nav 0 meaningful threads
#549 feat(data-fabric): support multiline_max field type and v2 single-record read 2 threads (API versioning question, not generalizable)
#543 feat: add multi-join support to Data Fabric entity queries 5 threads (2 actionable)
#580 fix(samples): update package-lock.json
#579 docs(governance): mark governance service and methods as experimental 1 thread (already documented)

…07-13)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude
claude Bot requested a review from a team July 13, 2026 10:05
@claude claude Bot added the claude-docs-update Automated Claude docs enhancement label Jul 13, 2026
@claude
claude Bot requested a review from ninja-shreyash July 13, 2026 10:05
@claude

claude Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

✅ No issues found. Checked for bugs and CLAUDE.md compliance.

@sonarqubecloud

Copy link
Copy Markdown

@ninja-shreyash
ninja-shreyash merged commit 9a9831e into main Jul 13, 2026
15 checks passed
@ninja-shreyash
ninja-shreyash deleted the claude-docs-update/2026-07-13 branch July 13, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-docs-update Automated Claude docs enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants