fix(auth): drop acr_values from OAuth flow, make no-acr the default - [PLT-107095]#608
Draft
Raina451 wants to merge 1 commit into
Draft
fix(auth): drop acr_values from OAuth flow, make no-acr the default - [PLT-107095]#608Raina451 wants to merge 1 commit into
Raina451 wants to merge 1 commit into
Conversation
The SDK appended acr_values (tenant:/tenantName:) to the authorize URL,
which routes auth directly to the org's SAML IdP. That blocked Basic Auth
users in mixed-auth orgs ("account not found"). setMultiLogin() existed only
to skip acr_values as a workaround.
Alpha testing confirms Identity now resolves the target org from client_id
alone, so acr_values is never needed and all auth types work without it.
Make no-acr the permanent default and remove the now-redundant setMultiLogin()
(it was @internal and became a no-op).
BREAKING CHANGE: removes the @internal setMultiLogin() from UiPath and IUiPath.
No-acr behavior is now automatic, so callers should delete setMultiLogin() calls.
Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
|
Raina451
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acr_valueswas added in #364 so Identity could resolve the org partition during the OIDC flow (needed then for SSO silent login and MS Entra). But it made Identity route straight to the org's SSO/SAML IdP always, which blocked Basic Auth users in mixed-auth orgs. #408 then added an internalsetMultiLogin()as an interim workaround: calling it droppedacr_valuesso the UiPath login picker showed instead of forced SSO.Identity has now fixed the root cause, it now resolves the correct partition from
client_id, soacr_valuesis no longer needed for any flow. This PR removes it entirely, makes no-acr the default, and drops the now-redundantsetMultiLogin().Tested in alpha, working across every login method: