Conversation
InsetOrderOptimizer::addToLayer now reads 'initial_layer_inset_direction' when processing layer 0 instead of always using 'inset_direction'. This enables a different wall/inset ordering for the first layer while preserving the existing setting for subsequent layers.
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
Looks good, and I don't think the comment is necessary. The code is self-explanatory enough.
Also you could add the condition directly inside the get to slightly reduce the code.
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: dbe932f | Previous: 3816773 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_slot_noplugin |
4.230196866851769 ns/iter |
2.607504276959351 ns/iter |
1.62 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
Test Results30 tests 30 ✅ 5s ⏱️ Results for commit fc95f76. ♻️ This comment has been updated with latest results. |
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
Great !! And by the way, this is a tiny but really nice feature ... I remember countless print failures of models with a lot of small holes in the bottom, that should definitely help ! And also we have better print beds nowadays 😄
|
Closed in favor of #2309 |
3 participants
InsetOrderOptimizer::addToLayer now reads 'initial_layer_inset_direction' when processing layer 0 instead of always using 'inset_direction'. This enables a different wall/inset ordering for the first layer while preserving the existing setting for subsequent layers.
Ultimaker/Cura#21431
CURA-13004