CURA-12996 Fix flooring areas being generated when disabled#2302
Open
wawanbreton wants to merge 4 commits intomainfrom
Open
CURA-12996 Fix flooring areas being generated when disabled#2302wawanbreton wants to merge 4 commits intomainfrom
wawanbreton wants to merge 4 commits intomainfrom
Conversation
Contributor
rburema
reviewed
Mar 5, 2026
Member
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 3e9dc3e | Previous: fb0206f | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_slot_noplugin |
1.9119220685025269 ns/iter |
1.2470258892889536 ns/iter |
1.53 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
casperlamboo
approved these changes
Mar 17, 2026
Contributor
casperlamboo
left a comment
casperlamboo
left a comment
There was a problem hiding this comment.
One small question, but otherwise approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would possibly generate flooring areas although the flooring layers count was 0. We now handle this case separately to really generate no flooring if not required.
CURA-12996