CURA-12829 Fix tree support top layer generation#2306
Merged
HellAholic merged 3 commits into5.13from Mar 18, 2026
Merged
Conversation
CURA-12829 The createTubeShape method was implemented on LinesSet, however it could not work with open polylines. It turns out we always use it with Shapes, which makes more sense. So moving the method to Shape and changing the call from the tree support generation (which also saves a conversion step).
casperlamboo
approved these changes
Mar 17, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug is a remnant of the geometry classes refactoring, hopefully the last one 😄
The
createTubeShapemethod was implemented onLinesSet, however it could not work with open polylines. It turns out we (almost) always used it withShapes, for which it works. So moving the method toShapeand changing the call from the tree support generation (which also saves a conversion step).CURA-12829