CURA-13025 Fix skin support with random infill start#2307
Merged
HellAholic merged 2 commits into5.13from Mar 18, 2026
Merged
Conversation
CURA-13025 The insertion of the skin support made it possible that we enter the upper-condition with only skin support lines, so the assumption that walls are generated in the last sub-condition is no more true. Now we properly test it, which avoids infinite loops and crashes.
Contributor
HellAholic
approved these changes
Mar 17, 2026
HellAholic
deleted the
CURA-13025_randomize-infill-start-with-infill-skin-support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The insertion of the skin support made it possible that we enter the upper-condition with only skin support lines, so the assumption that walls are generated in the last sub-condition is no more true. Now we properly test it, which avoids infinite loops and crashes.
CURA-13025