CURA-13032 Fix overhang speed factor being applied twice#2308
Merged
HellAholic merged 2 commits into5.13from Mar 18, 2026
Merged
CURA-13032 Fix overhang speed factor being applied twice#2308HellAholic merged 2 commits into5.13from
HellAholic merged 2 commits into5.13from
Conversation
Contributor
Test Results30 tests 30 ✅ 5s ⏱️ Results for commit 2f90c6a. ♻️ This comment has been updated with latest results. |
casperlamboo
approved these changes
Mar 17, 2026
HellAholic
deleted the
CURA-13032_overhanging-speed-reduction-applied-twice
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradual flow was setting the segment raw speed, using a modified speed that already has the
speed_factorapplied, thus later this factor would be applied once again.We now un-apply the base speed factor when setting the gradual-flow-reduced speed.
Hope that makes sense, otherwise just look at the code 😅
CURA-13032