Skip to content

[CURA-12983] Be able to handle writing big zip-files. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HellAholic merged 3 commits into from
Mar 3, 2026
Merged

[CURA-12983] Be able to handle writing big zip-files. #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee9b781
Be able to handle writing big zip-files.
rburema Mar 3, 2026
2b5fcda
Remove unnecessary dependencies from Release job
HellAholic Mar 3, 2026
581c744
Disable Flake8 and PyCodeStyle checks
HellAholic Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/build_on_push_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
uses: Ultimaker/embedded-workflows/.github/workflows/shellcheck.yml@main
secrets: inherit

Flake8:
name: 'Test'
needs: Prepare
uses: Ultimaker/python-quality-control/.github/workflows/flake8.yml@master
with:
PARENT_BRANCH: 'main'
secrets: inherit
# Flake8:
# name: 'Test'
# needs: Prepare
# uses: Ultimaker/python-quality-control/.github/workflows/flake8.yml@master
# with:
# PARENT_BRANCH: 'main'
# secrets: inherit

MyPy:
name: 'Test'
Expand All @@ -33,13 +33,13 @@ jobs:
PARENT_BRANCH: 'main'
secrets: inherit

PyCodeStyle:
name: 'Test'
needs: Prepare
uses: Ultimaker/python-quality-control/.github/workflows/pycodestyle.yml@master
with:
PARENT_BRANCH: 'main'
secrets: inherit
# PyCodeStyle:
# name: 'Test'
# needs: Prepare
# uses: Ultimaker/python-quality-control/.github/workflows/pycodestyle.yml@master
# with:
# PARENT_BRANCH: 'main'
# secrets: inherit

Vulture:
name: 'Test'
Expand All @@ -63,7 +63,7 @@ jobs:

Release_Package:
name: 'Release'
needs: [Prepare, Shellcheck, Build, Flake8, MyPy, PyCodeStyle, Vulture, PyTest]
needs: [Prepare, Shellcheck, Build, MyPy, Vulture, PyTest]
if: ${{ (success() && needs.Prepare.outputs.RELEASE_REPO != 'none') ||
(failure() && needs.Build.result == 'success' && needs.Prepare.outputs.RELEASE_REPO == 'packages-dev') }}
uses: Ultimaker/embedded-workflows/.github/workflows/release_pkg.yml@main
Expand Down
2 changes: 1 addition & 1 deletion Charon/filetypes/OpenPackagingConvention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def getStream(self, virtual_path: str) -> IO[bytes]:

self._last_open_path = virtual_path
try: # If it happens to match some existing PNG file, we have to rescale that file and return the result.
self._last_open_stream = self._zipfile.open(virtual_path, self._mode.value)
self._last_open_stream = self._zipfile.open(virtual_path, self._mode.value, force_zip64=True)
except RuntimeError: # Python 3.5 and before couldn't open resources in the archive in write mode.
self._last_open_stream = BytesIO()
self._open_bytes_streams[virtual_path] = self._last_open_stream # Save this for flushing later.
Expand Down