fix(ui): improve language legend dots on high DPI displays#2474
Open
srinidhi-2006-bit wants to merge 1 commit into
Open
fix(ui): improve language legend dots on high DPI displays#2474srinidhi-2006-bit wants to merge 1 commit into
srinidhi-2006-bit wants to merge 1 commit into
Conversation
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Contributor
Author
|
The failing Playwright checks appear to be unrelated to this change. This PR only updates the language legend indicator styling in The failing checks are coming from existing E2E/visual tests:
No functionality outside the Language Breakdown widget was modified in this PR. All relevant checks for this change pass successfully:
Requesting maintainer review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the rendering of language indicator dots in the Language Breakdown widget on Retina/HiDPI displays. The fixed-size dot implementation has been replaced with a DPI-friendly sizing approach to ensure the indicators remain crisp, properly sized, and visually consistent across different screen densities.
Closes #1058
Type of Change
🐛 Bug fix (non-breaking change that fixes an issue)
What Changed
Updated the language indicator dot styling in
src/components/LanguageBreakdown.tsxReplaced the fixed-size dot implementation with a DPI-friendly sizing approach using rem units
Preserved existing layout, alignment, and accessibility attributes while improving visibility on high-DPI displays
How to Test
Run the application using
npm run devNavigate to the dashboard and open the Language Breakdown widget
Verify the language legend indicators on different zoom levels or a HiDPI/Retina display
Expected result:
Language indicator dots appear crisp, properly sized, and aligned with their corresponding labels without causing layout regressions.
Screenshots / Recordings
Before | After -- | -- Small or blurry dots on HiDPI displays | Clear and properly sized dots on HiDPI displaysChecklist
Linked the related issue above
Self-reviewed my own diff
No unnecessary
console.log, debug code, or commented-out blocksnpm run lintpasses locallyNo TypeScript errors (
npm run type-check)Added or updated tests where applicable
Updated documentation / comments if behavior changed
Accessibility (UI changes only)
Keyboard navigation works correctly
Color contrast meets WCAG AA standard
ARIA labels / roles added where needed
Tested on mobile / responsive layout
Additional Context
This change only affects the visual rendering of language legend indicators and does not modify any existing functionality, data processing, or user interactions.
Summary
Improves the rendering of language indicator dots in the Language Breakdown widget on Retina/HiDPI displays. The fixed-size dot implementation has been replaced with a DPI-friendly sizing approach to ensure the indicators remain crisp, properly sized, and visually consistent across different screen densities.
Closes #1058
Type of Change
🐛 Bug fix (non-breaking change that fixes an issue)
What Changed
Updated the language indicator dot styling in
src/components/LanguageBreakdown.tsxReplaced the fixed-size dot implementation with a DPI-friendly sizing approach using rem units
Preserved existing layout, alignment, and accessibility attributes while improving visibility on high-DPI displays
How to Test
Run the application using
npm run devNavigate to the dashboard and open the Language Breakdown widget
Verify the language legend indicators on different zoom levels or a HiDPI/Retina display
Expected result:
Language indicator dots appear crisp, properly sized, and aligned with their corresponding labels without causing layout regressions.
Screenshots / Recordings
Before | After -- | -- Small or blurry dots on HiDPI displays | Clear and properly sized dots on HiDPI displaysChecklist
Linked the related issue above
Self-reviewed my own diff
No unnecessary
console.log, debug code, or commented-out blocksnpm run lintpasses locallyNo TypeScript errors (
npm run type-check)Added or updated tests where applicable
Updated documentation / comments if behavior changed
Accessibility (UI changes only)
Keyboard navigation works correctly
Color contrast meets WCAG AA standard
ARIA labels / roles added where needed
Tested on mobile / responsive layout
Additional Context
This change only affects the visual rendering of language legend indicators and does not modify any existing functionality, data processing, or user interactions.