Skip to content

Refactor privacy notice dialog to return a Future #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FreelancerAlpha1Dash1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor privacy notice dialog to return a Future #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/modules/main/application/main_screen_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ class MainScreenLogic {
}
}

Future<void> checkAndShowPrivacyNotice(Function showDialog) async {
Future<void> checkAndShowPrivacyNotice(Future<void> Function() showDialog) async {
final prefs = await SharedPreferences.getInstance();
final bool privacyNoticeShown = prefs.getBool('privacy_notice_shown') ?? false;
if (!privacyNoticeShown) {
showDialog();
return showDialog();
}
}

Expand Down
4 changes: 2 additions & 2 deletions lib/modules/main/presentation/screens/main_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ class _MainScreenState extends ConsumerState<MainScreen> {
_secretTapHandler.handleSecretTap(context);
}

void _showPrivacyNoticeDialog() {
PrivacyNoticeDialog.show(
Future<void> _showPrivacyNoticeDialog() {
return PrivacyNoticeDialog.show(
context,
() async {
if (ref.context.mounted) {
Expand Down