Add vcpkg SDL3 to CI and update UI demo to use UiState; require SDL3 CONFIG in CMake#3
Merged
Add vcpkg SDL3 to CI and update UI demo to use UiState; require SDL3 CONFIG in CMake#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
vcpkgand using vcpkg triplets.vcpkgby usingfind_package(SDL3 CONFIG REQUIRED)to locate vcpkg-provided SDL3.UiStateinstead ofUiAppand prints the rendering API name safely withImGui::Text.Description
.github/workflows/cmake-multi-platform.ymlto addlukka/run-vcpkg@v11, installsdl3viavcpkg, addvcpkg_tripletentries to the matrix, and pass-DCMAKE_TOOLCHAIN_FILEand-DVCPKG_TARGET_TRIPLETto CMake configure.find_package(SDL3 REQUIRED)tofind_package(SDL3 CONFIG REQUIRED)inCMakeLists.txtto favor config-mode discovery from vcpkg.src_demo/window_demo.handsrc_demo/window_demo.cppto change the signature frombool UiUpdate(UiApp&)tobool UiUpdate(UiState&), updated usage tostate.app->GetRenderingApiName(), and adjusted theImGui::Textcall to use"%s"withc_str().Testing
mainusing the newvcpkgsteps.Codex Task