Improve notification profile form design#1804
Conversation
c12f708 to
5c2a773
Compare
2f1f56d to
baef7f4
Compare
Test results 6 files 990 suites 1m 56s ⏱️ Results for commit 546b63a. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1804 +/- ##
==========================================
+ Coverage 86.18% 86.72% +0.53%
==========================================
Files 137 137
Lines 6711 6705 -6
==========================================
+ Hits 5784 5815 +31
+ Misses 927 890 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fac9763 to
e096dcc
Compare
a6edfb2 to
e601f76
Compare
5c2a773 to
4fbf798
Compare
3f999ec to
788e3db
Compare
b9bca63 to
f0aab19
Compare
2ce87b7 to
728dfcd
Compare
f0aab19 to
3d5e71a
Compare
d01905b to
728dfcd
Compare
aleksfl
left a comment
There was a problem hiding this comment.
Has the same bug as the timeslots PR with the expand arrow, but otherwise it works as intended. Given that the bug was fixed for the related PRs and my comments are tiny, am approving anyways.
lunkwill42
left a comment
There was a problem hiding this comment.
Looks very nice! 😃
Only small nitpicks (no code deep-dive from me today):
- When I click the button to create my first profile, the message "No profiles yet." remains visible below the form card. While technically true, it seems somewhat confusing as I am currently adding a profile..
- The "active" checkbox moves around when I add destinations:
simplescreenrecorder-2026-02-25_14.33.10.mp4
3d5e71a to
0d07d88
Compare
728dfcd to
f0fea9b
Compare
|
❌ The last analysis has failed. |
0d07d88 to
6722282
Compare
3f03830 to
e45595c
Compare
There was a problem hiding this comment.
When I click the New Profile button I get some errors in the console:
'#no-profiles-message' is null hyperscript-0.9.13.min.js:1:54742
,
hypertrace /// hyperscript-0.9.13.min.js:1:23402
and
-> on click -
<button class="btn btn-primary htmx-request" hx-get="/notifications/profiles/create/" hx-target="#notificationprofile-create" hx-swap="outerHTML" _="on click remove #no-profiles-message">
hyperscript-0.9.13.min.js:1:23549
6722282 to
7235d14
Compare
e45595c to
803095c
Compare
This is fixed now :) The issue was that the hyperscript did not account for the element possibly missing from the page. |
These visual bugs are now fixed 😄 |
87c69df to
6372d97
Compare
96bdcc4 to
546b63a
Compare
546b63a to
9458503
Compare
|







Scope and purpose
Resolves issue #1796, based on PR #1797 and PR #1799
This pull request
Reworks notification profile forms to match the accordion card pattern from #1794.
<select multiple>for filters and destinations instead of customDropdownMultiSelectScreenshots
Contributor Checklist