Skip to content

Show name of owner for public filters#1810

Merged
johannaengland merged 2 commits intoUninett:mainfrom
johannaengland:feature/add-username-to-public-filters
Mar 2, 2026
Merged

Show name of owner for public filters#1810
johannaengland merged 2 commits intoUninett:mainfrom
johannaengland:feature/add-username-to-public-filters

Conversation

@johannaengland
Copy link
Copy Markdown
Contributor

@johannaengland johannaengland commented Feb 24, 2026

Scope and purpose

Fixes #1748.

Screenshots:
Before:
image

After:
image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@johannaengland johannaengland requested review from a team and Simrayz February 24, 2026 10:37
@johannaengland johannaengland self-assigned this Feb 24, 2026
@johannaengland johannaengland added the frontend Affects frontend label Feb 24, 2026
@johannaengland johannaengland marked this pull request as draft February 24, 2026 10:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.58%. Comparing base (44b19cd) to head (2ac9a22).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/argus/htmx/incident/filter.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1810      +/-   ##
==========================================
+ Coverage   84.57%   84.58%   +0.01%     
==========================================
  Files         136      136              
  Lines        6619     6630      +11     
==========================================
+ Hits         5598     5608      +10     
- Misses       1021     1022       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johannaengland johannaengland force-pushed the feature/add-username-to-public-filters branch from 82284af to 12ca4f9 Compare February 24, 2026 11:01
@johannaengland johannaengland marked this pull request as ready for review February 24, 2026 11:02
@Simrayz
Copy link
Copy Markdown
Contributor

Simrayz commented Feb 24, 2026

I don't think that this design separates the user login from the filter name clearly enough. We already have a pattern in the PM Task form, maybe use that instead? I.e. <filter name> (<username>). Thisclearly shows that the filter owner is secondary (but important to distinguish similar results)
image

Copy link
Copy Markdown
Contributor

@Simrayz Simrayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

@johannaengland johannaengland force-pushed the feature/add-username-to-public-filters branch from 4704e9b to 2ac9a22 Compare March 2, 2026 09:40
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 2, 2026

@johannaengland johannaengland merged commit 2b24f29 into Uninett:main Mar 2, 2026
17 of 18 checks passed
@johannaengland johannaengland deleted the feature/add-username-to-public-filters branch March 2, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Affects frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark public filters in UI somehow

2 participants