fix: MyContext.send() ne doit pas planter si la suppression du message échoue#86
Merged
Conversation
Enveloppe l'appel à message.delete() dans un try/except discord.HTTPException. Sans ça, la commande $prez (seule à utiliser delete_after=None, donc le chemin de suppression immédiate et bloquante) plante silencieusement si le bot n'a pas la permission "Gérer les messages" : l'exception interrompt la commande avant même l'envoi de la réponse. Closes #85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
MyContext.send()(src/urpy/my_commands.py) enveloppe désormaisself.message.delete()dans untry/except discord.HTTPException.\$prez(la seule commande à utiliserdelete_after=None, donc le chemin de suppression immédiate et bloquante de discord.py) échoue totalement en silence si le bot n'a pas la permission Gérer les messages : l'exceptionForbiddeninterrompt la commande avant l'envoi de la réponse.Closes #85
Test plan
\$prezrépond désormais (message d'erreur "channel not found" ou succès) même sans la permission Gérer les messages.