fix: crash sur $version/$credit et $done/$cancel sans session#63
Merged
Conversation
- get_credits()/get_version()/get_name() utilisent resources.read_text() mais 'from importlib import resources' n'était jamais importé (NameError). Resté invisible tant que ce cog ne chargeait pas du tout (voir #58, #60) : $version/$credit énumèrent tous les cogs chargés et appellent get_name() sur chacun. - on_cancel_or_done() (callback partagé de $done et $cancel) supprimait self.edit_mode_users[author] sans vérifier que la clé existe, contrairement à on_done()/on_cancel() qui vérifient bien l'appartenance avant toute opération. KeyError dès que $done ou $cancel est tapé sans session d'édition active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62
Deux crashes constatés en production juste après le déploiement Docker :
resources(importlib) → NameError sur$version/$crediton_cancel_or_donesans garde de présence → KeyError sur$done/$cancelhors sessionVoir #62 pour le détail complet.