Open
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review summary:
- A potentially incorrect version (
2.8.4) was found for thecom.unity.splinesdependency, which might cause package resolution failures. - Verification is needed on whether the dependency version jump is strictly necessary for compatibility.
🤖 Helpful? 👍/👎
| "category": "cinematography", | ||
| "dependencies": { | ||
| "com.unity.splines": "2.0.0", | ||
| "com.unity.splines": "2.8.4", |
Contributor
There was a problem hiding this comment.
Is 2.8.4 the correct version for com.unity.splines? The latest known release for the Splines package is 2.8.3, whereas 2.8.4 happens to be a previous version of com.unity.cinemachine. Using a non-existent version will cause a package resolution failure in the Unity Package Manager and prevent the project from compiling.
If 2.8.4 is indeed unreleased or a typo, you might want to switch it to 2.8.3 or another valid version.
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage 17.07% 17.07%
=======================================
Files 209 209
Lines 23759 23759
=======================================
Hits 4058 4058
Misses 19701 19701
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Delete any line or section that does not apply]
Purpose of this PR
[JIRA issue. Desc of feature/change. Links to screenshots, design docs, user docs, etc. Remember reviewers may be outside your team, and not know your feature/area that should be explained more.]
Testing status
[Explanation of what’s tested, how tested and existing or new automation tests. Can include manual testing by self and/or QA. Specify test plans. Rarely acceptable to have no testing.]
Documentation status
[Overview of how documentation is affected by this change. If there is no effect on documentation, explain why. Otherwise, state which sections are changed and why.]
Technical risk
[Overall product level assessment of risk of change. Need technical risk & halo effect.]
Comments to reviewers
[Info per person for what to focus on, or historical info to understand who have previously reviewed and coverage. Help them get context.]
Package version
[Justification for updating either the patch, minor, or major version according to the semantic versioning rules]