chore: Asteroids internal to experimental project sync #199
chore: Asteroids internal to experimental project sync #199NoelStephensUnity wants to merge 1 commit intomainfrom
Conversation
fernando-cortez
left a comment
fernando-cortez
left a comment
There was a problem hiding this comment.
Tiny cleanup changes!
| @@ -158,6 +158,10 @@ private void Update() | |||
|
|
|||
| private void UpdateInput() | |||
There was a problem hiding this comment.
I see that there was a previous version of this method below. We could remove that version?
| @@ -49,23 +49,52 @@ public override void OnNetworkSpawn() | |||
|
|
|||
There was a problem hiding this comment.
I believe some unused methods & class variables can be removed here.
| @@ -0,0 +1,149 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Could this best serve inside testproject or the internal project? It's unclear what to do inside the SerializationValidation scene, and if it's a validator of features, and not necessarily a use-case it might be best kept internally? Thoughts?
If it needs to be added to the project, this scene needs to be added to the Scene List in BuildSettings.
|
Hi team, trying to do some cleanup here. @fernando-cortez / @NoelStephensUnity is this PR still valid / needed, or should we close it? |
3 participants
Description
Updating the experimental public asteroids project with the most recent updates to the internal asteroids project based on the most recent fixes and updates for NGO v2.0.0-pre.3 and the MPS SDK v1.0.0-pre.1 updates.
Issue Number(s)
A long list of issues resolved internally and verified fixed over past two play tests.
Contribution checklist