fix(ui-uitk): strip hidden U+FE0F and link orphaned reference files - #44
Open
chris-addison wants to merge 1 commit into
Open
fix(ui-uitk): strip hidden U+FE0F and link orphaned reference files#44chris-addison wants to merge 1 commit into
chris-addison wants to merge 1 commit into
Conversation
The skills.sh Snyk W021 hidden-Unicode audit (SEC_HIDDEN_UNICODE) flagged a U+FE0F variation selector trailing the warning glyph in skills/ui-uitk/references/custom-elements.md:20. Strip it and keep the visible U+26A0 glyph, which is how the rest of the repo already writes that character. Also convert the reference-list entries in ui-uitk and ui-ugui from backticked paths to markdown links, clearing eight REF_ORPHAN warnings. The validator strips inline code before collecting link targets, so a backticked path never counted as a link and the files read as unreachable. ui-imgui already uses the linked form, and the same conversion landed for levelplay in #38. No reference files were added, removed, or renamed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs small documentation-hygiene fixes for Unity UI skills to satisfy repository validation: it removes a hidden Unicode variation selector (U+FE0F) and converts “orphaned” reference-path listings into real Markdown links so validators can detect them.
Changes:
- Convert
ui-uitkreference list entries from backticked paths to Markdown links. - Strip the hidden U+FE0F variation selector from a heading in
ui-uitkreference docs while preserving the visible warning glyph. - Convert the
ui-uguiScrollView reference entry into a Markdown link.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| skills/ui-uitk/SKILL.md | Converts reference entries to Markdown links so reference files are link-reachable by validators. |
| skills/ui-uitk/references/custom-elements.md | Removes hidden U+FE0F variation selector from a heading to resolve hidden-unicode validation errors. |
| skills/ui-ugui/SKILL.md | Converts the ScrollView reference entry to a Markdown link to prevent orphaned-reference warnings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related documentation-hygiene fixes in the UI skills. Grouped into one PR since both are validator findings from the same run and the diff is nine lines; CONTRIBUTING allows batching related skills when noted.
1. Hidden Unicode (the error)
The skills.sh Snyk W021 audit flagged
SEC_HIDDEN_UNICODEinui-uitk:A
U+FE0Fvariation selector trailed the warning glyph in the heading on line 20. It is stripped; the visibleU+26A0glyph is kept, so the heading still renders as### ⚠ CRITICAL: Namespace Declaration. That bare form is already how the rest of the repo writes the glyph (seelevelplay-unity-integration/references/best-practices.md).A scan of every
.md/.json/.yaml/.txtfile in the repo for variation selectors, BOM, zero-width, bidi-control and soft-hyphen characters confirms this was the only occurrence, and that the tree is now clean.2. Orphaned reference files (the warnings)
The same run reported eight
REF_ORPHANwarnings — seven inui-uitk, one inui-ugui.The files were not actually undocumented: both SKILL.md files listed them, but as backticked paths rather than markdown links. The validator strips inline code before collecting link targets, so a backticked path never counts as a link and the reference reads as unreachable.
Converted the reference-list entries to markdown links. This matches
ui-imgui, which already uses the linked form, and mirrors the same conversion made forlevelplay-unity-integrationin #38. Inline prose mentions elsewhere in the body are left as backticks, also matchingui-imgui.No reference files were added, removed, or renamed.
Verification
Before → after for the two affected skills:
ui-uitkui-uguiNote for reviewers
The same validator run reports a pre-existing
HUB_LEAKerror inunity-cli/SECURITY.md:21onmain. It is unrelated to this change and is already addressed on the in-flightunity-cli/safe-mode-recovery-and-install-accuracybranch, so it is deliberately untouched here.