Skip to content

fix: Update fulfilment test to treat [] and None equally. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
semenovm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Update fulfilment test to treat [] and None equally. #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fulfillment_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,9 @@ def test_unknown_customer_no_address(self) -> None:

# Verify no destinations injected
method = updated_checkout.fulfillment.root.methods[0]
self.assertIsNone(method.destinations)
self.assertTrue(
method.destinations is None or len(method.destinations) == 0
)

def test_known_customer_no_address(self) -> None:
"""Test that a known customer with no stored address gets no injection."""
Expand All @@ -230,7 +232,9 @@ def test_known_customer_no_address(self) -> None:
updated_checkout = checkout.Checkout(**response_json)

method = updated_checkout.fulfillment.root.methods[0]
self.assertIsNone(method.destinations)
self.assertTrue(
method.destinations is None or len(method.destinations) == 0
)

def test_known_customer_one_address(self) -> None:
"""Test that a known customer with an address gets it injected."""
Expand Down
Loading