chore: Update CODEOWNERS to implement hierarchical authority#15
Conversation
|
@amithanda - can you please take a look? |
amithanda
left a comment
There was a problem hiding this comment.
One thing to highlight, not sure if you have already considered:
Would this lead to a lot of email spam?
The Problem: The PR lists multiple teams on almost every line.
The GitHub Behavior: GitHub will recognize that an approval from any one of these teams satisfies the requirement. HOWEVER, when a PR is opened, GitHub automatically requests a review from all the teams listed on that line.
The Impact: The tech-council and governance-council will receive an automatic review request and notification for every single Pull Request opened in this repository, even minor typo fixes or simple code changes.
Potential Suggestion:
Keep the codeowner file clean and Implement Hierarchy via Branch Protection Settings e.g
# Default for all files
* @Universal-Commerce-Protocol/maintainers
# Infrastructure, Tooling & Configuration
/.github/ @Universal-Commerce-Protocol/devops-maintainers
/.gitignore @Universal-Commerce-Protocol/devops-maintainers
/.pre-commit-config.yaml @Universal-Commerce-Protocol/devops-maintainers
/pyproject.toml @Universal-Commerce-Protocol/devops-maintainers
/uv.lock @Universal-Commerce-Protocol/devops-maintainers
# Governance
/LICENSE @Universal-Commerce-Protocol/governance-council
/.github/CODEOWNERS @Universal-Commerce-Protocol/governance-council
The result:
Only the maintainers or devops-maintainers will be automatically pinged for standard infrastructure PRs.
However, if the tech-council or governance-council needs to step in, their elevated permissions allow them to review and merge the PR immediately, fulfilling the hierarchical requirement without the spam.
amithanda
left a comment
There was a problem hiding this comment.
Thanks for addressing the notification emails issue. Approving.
87e5275
into
Universal-Commerce-Protocol:main
Description
Update CODEOWNERS to implement a hierarchical authority structure and ensure comprehensive ownership of critical infrastructure and governance files.
Key changes:
@Universal-Commerce-Protocol/governance-council for ecosystem-wide consistency.
Github Settings to control noise:
To ensure hierarchical authority without generating unnecessary email noise for senior teams, we will implement the following configuration in conjunction with this PR:
Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Checklist
Screenshots / Logs (if applicable)