Merged
Conversation
0x8000-0000
suggested changes
Feb 10, 2026
samali0996
reviewed
Feb 16, 2026
Contributor
|
Hi @damaz91, Could you please incorporate the suggestions? Thank you. |
Change-Id: I7400c7bd870e3505d5b8c9a9e179d305c65bb3dc
Change-Id: I4583f94619b072eb7aff0fc28f040d0b2fd30de3
Contributor
Author
All suggestions have been addressed |
Change-Id: Ib7d74192095677f98a79906f5ed2d69dc16e1520
Change-Id: I2e70bdaf468ef7663b6c8e7542f2acf822d9df06
Change-Id: Id33ccc029b86af2486c82dc85d8bb12b3c55c680
Change-Id: Ia518ec52de6906da7262f7a76704a676a6318c40
Change-Id: I113bf00366152f552140a0f6410f738813c44007
Change-Id: I8413a4ad2e3886df6684ff7f654faa2ed2a95043
0x8000-0000
approved these changes
Mar 2, 2026
| ) | ||
| id: str | ||
| """ | ||
| model_config = ConfigDict( |
There was a problem hiding this comment.
Are these formatting changes necessary? Will they be applied to all other Python projects under UCP?
MitkoDeyanovMitev
approved these changes
Mar 2, 2026
MitkoDeyanovMitev
left a comment
MitkoDeyanovMitev
left a comment
There was a problem hiding this comment.
looks good, if possible you can add the request and response classes
Change-Id: I63be54dcfc253861c05a9143483fd73a98f2c232
Change-Id: If59a9d92e40d71bc9d69d171b7020310ee9e26a1
Change-Id: I79bccca52f3a1d9d721c6a6f10d128f544411840
Change-Id: I0ac8995f2d15caa97ce57e9a1be574f012d5b9f2
wry-ry
requested changes
Mar 2, 2026
wry-ry
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant improvements and refactorings to the Python SDK for the Universal Commerce Protocol (UCP). The changes focus on automating schema preprocessing and model generation, updating project metadata, refactoring the discovery profile models, and cleaning up unused code. The most important changes are grouped below:
Automated Model Generation & Schema Preprocessing
preprocess_schemas.pyscript to preprocess UCP JSON schemas, generate operation-specific variants, and handle reference propagation for accurate model generation. This script is now called bygenerate_models.shbefore running codegen.generate_models.shto accept a UCP spec version, clone the correct branch, run schema preprocessing, and improve formatting of generated models. Formatting is now separated from code generation for clarity. [1] [2] [3]README.mdto reflect the new model generation workflow, including version selection and schema preprocessing details. [1] [2]Discovery Profile Model Refactor
src/ucp_sdk/models/discovery/profile_schema.pyto support both platform and business discovery profiles, using new base schemas and type-safe root models. This change aligns the SDK with the latest UCP spec and improves clarity and extensibility. [1] [2]Project Metadata and Licensing
pyproject.tomlto reflect the new versioning scheme, add additional authors, and include license files for improved compliance and attribution.Codebase Cleanup
src/ucp_sdk/__init__.pyandsrc/ucp_sdk/models/_internal.py, streamlining the SDK and reducing maintenance overhead. [1] [2]Miscellaneous
__init__.pyfiles to ensure proper formatting and future extensibility.Let me know if you have questions about any of these changes or want to dive deeper into the schema preprocessing or discovery profile refactor!