fix: Add missing mock payment handler to discovery profile#39
Open
dkoch74 wants to merge 2 commits intoUniversal-Commerce-Protocol:mainfrom
Open
fix: Add missing mock payment handler to discovery profile#39dkoch74 wants to merge 2 commits intoUniversal-Commerce-Protocol:mainfrom
dkoch74 wants to merge 2 commits intoUniversal-Commerce-Protocol:mainfrom
Conversation
dkoch74
commented
Mar 9, 2026
Author
dkoch74
left a comment
dkoch74
left a comment
There was a problem hiding this comment.
Please take a look - this is needed to make the happy path sample code function as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue with the sample client erroring when ran as directed in README.
A mock payment handler expected by the example client was removed in #29 along with cleanup of some invalid spec URLs. The mock payment handler does not have valid spec URLs (it's a mock) of course, but it is necessary for the sample
client to function, as the sample client does not have a UI nor is it actually integrated with the Google Pay or Shop Pay
handlers.