Declare category additions as readonly properties, instead of instance methods, for better Swift compatibility#19
Open
JRG-Developer wants to merge 1 commit intoUrbanApps:masterfrom
Open
Conversation
…e methods. This way, they are correctly converted to Swift computed properties automatically.
Member
|
We used to have it like this, but I can't remember why we changed it, maybe subclassing reasons? Seeing as swift is the future, I am inclined to accept the PR, but it's been awhile since I've done any obj-c dev and want to hear from others about the potential pitfalls from removing |
RomanPodymov
reviewed
Oct 3, 2020
There was a problem hiding this comment.
Hello @JRG-Developer
There are no UAObfuscatedString.h and UAObfuscatedString.m in the project. Please close this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes category additions to readonly properties, instead of instance methods.
This way, they are correctly converted to Swift computed properties automatically.
Otherwise, as with the current version, you'd need to declare obfuscated strings like this:
With this PR accepted, you'll be able to declare obfuscated strings as intended like this: