deposits refactor completions (partial)#3328
Conversation
GitHub Actions
Inactive
GitHub Actions
Inactive
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new database migration to update the charges_bank_deposits table by replacing the deposit_id column with a new UUID-based column, along with adding a foreign key constraint and an index. Review feedback identifies a naming inconsistency in run-pg-migrations.ts where the imported variable name's timestamp does not match the migration's filename.
| import migration_2026_04_13T10_00_00_add_business_dates_to_user_context from './actions/2026-04-13T10-00-00.add-business-dates-to-user-context.js'; | ||
| import migration_2026_04_13T12_00_00_annual_audit_step_status from './actions/2026-04-13T12-00-00.annual-audit-step-status.js'; | ||
| import migration_2026_04_14T10_00_00_bank_deposits_table from './actions/2026-04-14T10-00-00.bank-deposits-table.js'; | ||
| import migration_2026_04_14T10_00_00_bank_deposits_table2 from './actions/2026-04-14T11-00-00.bank-deposits-table2.js'; |
There was a problem hiding this comment.
The variable name migration_2026_04_14T10_00_00_bank_deposits_table2 is inconsistent with the actual timestamp in the migration's filename (11-00-00). It should be updated to migration_2026_04_14T11_00_00_bank_deposits_table2 to match the file and follow the established naming convention in this repository.
| import migration_2026_04_14T10_00_00_bank_deposits_table2 from './actions/2026-04-14T11-00-00.bank-deposits-table2.js'; | |
| import migration_2026_04_14T11_00_00_bank_deposits_table2 from './actions/2026-04-14T11-00-00.bank-deposits-table2.js'; |
| migration_2026_04_13T10_00_00_add_business_dates_to_user_context, | ||
| migration_2026_04_13T12_00_00_annual_audit_step_status, | ||
| migration_2026_04_14T10_00_00_bank_deposits_table, | ||
| migration_2026_04_14T10_00_00_bank_deposits_table2, |
There was a problem hiding this comment.
Update the variable name in the MIGRATIONS array to match the corrected import name (using the 11_00_00 timestamp).
| migration_2026_04_14T10_00_00_bank_deposits_table2, | |
| migration_2026_04_14T11_00_00_bank_deposits_table2, |
479fdb9 to
e8417b7
Compare
1 participant
No description provided.