Skip to content

All Charges screen performance boost: Defer missingInfoSuggestions#4030

Merged
gilgardosh merged 2 commits into
mainfrom
all-charges-performance-boost-3
Jul 22, 2026
Merged

All Charges screen performance boost: Defer missingInfoSuggestions#4030
gilgardosh merged 2 commits into
mainfrom
all-charges-performance-boost-3

Conversation

@gilgardosh

Copy link
Copy Markdown
Collaborator

No description provided.

@gilgardosh gilgardosh self-assigned this Jul 22, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the client-side Charges table GraphQL selection to fetch missingInfoSuggestions via a deferred fragment, reducing the initial payload size and allowing suggestions to stream in later.

Changes:

  • Extracted missingInfoSuggestions into a dedicated ChargesTableSuggestionsFields fragment.
  • Applied @defer to the suggestions fragment spread inside ChargeForChargesTableFields.
  • Updated convertChargeFragmentToTableRow to read suggestions via getFragmentData and handle the deferred (initially-absent) fields safely.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gilgardosh gilgardosh changed the title Defer missingInfoSuggestions All Charges screen performance boost: Defer missingInfoSuggestions Jul 22, 2026
@gilgardosh
gilgardosh force-pushed the all-charges-performance-boost-2 branch from a08d772 to fd85a0b Compare July 22, 2026 14:19
@gilgardosh
gilgardosh force-pushed the all-charges-performance-boost-3 branch from 0a9520e to c2a12da Compare July 22, 2026 14:21
@gilgardosh
gilgardosh temporarily deployed to accounter-fullstack July 22, 2026 14:21 — with GitHub Actions Inactive
@gilgardosh
gilgardosh temporarily deployed to accounter-fullstack July 22, 2026 14:21 — with GitHub Actions Inactive
@gilgardosh
gilgardosh force-pushed the all-charges-performance-boost-2 branch from fd85a0b to 8fbd04e Compare July 22, 2026 14:34
@gilgardosh
gilgardosh force-pushed the all-charges-performance-boost-3 branch from c2a12da to e039488 Compare July 22, 2026 14:35
@gilgardosh
gilgardosh temporarily deployed to accounter-fullstack July 22, 2026 14:35 — with GitHub Actions Inactive
@gilgardosh
gilgardosh temporarily deployed to accounter-fullstack July 22, 2026 14:35 — with GitHub Actions Inactive
@gilgardosh
gilgardosh force-pushed the all-charges-performance-boost-3 branch from e039488 to 01225f5 Compare July 22, 2026 14:39
@gilgardosh
gilgardosh temporarily deployed to accounter-fullstack July 22, 2026 14:39 — with GitHub Actions Inactive
@gilgardosh
gilgardosh temporarily deployed to accounter-fullstack July 22, 2026 14:39 — with GitHub Actions Inactive
Base automatically changed from all-charges-performance-boost-2 to main July 22, 2026 14:42
@gilgardosh
gilgardosh force-pushed the all-charges-performance-boost-3 branch from 01225f5 to 17a8543 Compare July 22, 2026 14:43
@gilgardosh
gilgardosh temporarily deployed to accounter-fullstack July 22, 2026 14:43 — with GitHub Actions Inactive
@gilgardosh
gilgardosh temporarily deployed to accounter-fullstack July 22, 2026 14:44 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@accounter/client 0.1.0-alpha-20260722144541-d65f85ac51d3b00e186d8a45b25637732244b3af npm ↗︎ unpkg ↗︎
@accounter/gmail-listener 0.1.3-alpha-20260722144541-d65f85ac51d3b00e186d8a45b25637732244b3af npm ↗︎ unpkg ↗︎
@accounter/israeli-vat-scraper 0.1.13-alpha-20260722144541-d65f85ac51d3b00e186d8a45b25637732244b3af npm ↗︎ unpkg ↗︎
@accounter/modern-poalim-scraper 0.10.7-alpha-20260722144541-d65f85ac51d3b00e186d8a45b25637732244b3af npm ↗︎ unpkg ↗︎
@accounter/scraper-app 0.0.3-alpha-20260722144541-d65f85ac51d3b00e186d8a45b25637732244b3af npm ↗︎ unpkg ↗︎
@accounter/server 0.2.0-alpha-20260722144541-d65f85ac51d3b00e186d8a45b25637732244b3af npm ↗︎ unpkg ↗︎
@accounter/shaam-uniform-format-generator 0.2.7-alpha-20260722144541-d65f85ac51d3b00e186d8a45b25637732244b3af npm ↗︎ unpkg ↗︎
@accounter/shaam6111-generator 0.1.9-alpha-20260722144541-d65f85ac51d3b00e186d8a45b25637732244b3af npm ↗︎ unpkg ↗︎

@gilgardosh
gilgardosh merged commit 72e1632 into main Jul 22, 2026
11 checks passed
@gilgardosh
gilgardosh deleted the all-charges-performance-boost-3 branch July 22, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants