Skip to content

Feature: {username}/service - #7

Open
10808249 wants to merge 14 commits into
mainfrom
feature-service
Open

Feature: {username}/service#7
10808249 wants to merge 14 commits into
mainfrom
feature-service

Conversation

@10808249

Copy link
Copy Markdown

In progress

@10808249

Copy link
Copy Markdown
Author
  • Added new endpoint /la3/{username}/service
  • Imported some code from lets-auth-2
  • Added error handling part

@10808249
10808249 marked this pull request as ready for review September 29, 2022 20:01
@10808249

Copy link
Copy Markdown
Author
Serving Let's Authenticate version 3 API on localhost:3060
Beginning serving request /la3/user1234/service
Opening up old database (model...certHelpers)
Bad device cert PEM in authorize().
Opening up old database (model...certHelpers)
invalid PEM string for Certificate
Opening up old database (model...certHelpers)
invalid PEM string for Certificate
2022/09/29 13:59:52 http: superfluous response.WriteHeader call from github.com/Usable-Security-and-Privacy-Lab/lets-auth-ca/api.ObtainNewCertificate (username.go:67)2022/09/29 13:59:52 http: superfluous response.WriteHeader call from github.com/Usable-Security-and-Privacy-Lab/lets-auth-ca/api.jsonResponse (account.go:303)        
Finished serving request /la3/user1234/service

Now that all the grammatical errors have been fixed, it seems that the technical problem remains.

@zappala

zappala commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

This pulls in too much code from the old CA, a lot of it using the old database connections instead of GORM. Can you redo this, and bring in only the code that is needed to make this new endpoint work? You will need to rewrite the code you bring in to be sure it uses GORM to talk to the database.

@10808249

Copy link
Copy Markdown
Author

I have cleaned up the legacy code. The only assignment left is to modify the rsa.go to fit with new CA.

@10808249
10808249 requested a review from zappala November 16, 2022 19:14
@10808249 10808249 mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants