Feature: {username}/service - #7
Open
10808249 wants to merge 14 commits into
Open
Conversation
Author
|
10808249
force-pushed
the
feature-service
branch
from
September 29, 2022 20:01
df4d3b2 to
2487a86
Compare
10808249
marked this pull request as ready for review
September 29, 2022 20:01
Author
Now that all the grammatical errors have been fixed, it seems that the technical problem remains. |
Contributor
|
This pulls in too much code from the old CA, a lot of it using the old database connections instead of GORM. Can you redo this, and bring in only the code that is needed to make this new endpoint work? You will need to rewrite the code you bring in to be sure it uses GORM to talk to the database. |
Author
|
I have cleaned up the legacy code. The only assignment left is to modify the rsa.go to fit with new CA. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In progress