fix: add actionable warning for background requests during replay#139
fix: add actionable warning for background requests during replay#139sohil-kshirsagar merged 2 commits intomainfrom
Conversation
bc07ea1 to
2e7b2fd
Compare
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/instrumentation/libraries/firestore/Instrumentation.ts">
<violation number="1" location="src/instrumentation/libraries/firestore/Instrumentation.ts:706">
P2: Calling `doc("")` here can throw instead of generating an auto-ID, so replayed background `collection.add()` no-ops may fail immediately.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
2e7b2fd to
99daddd
Compare
Generated 11 tests - 11 passedTip New to Tusk Unit Tests? Learn more here. Test Summary
ResultsTusk's tests all pass. The test suite validates the core routing logic in View check history
Was Tusk helpful? Give feedback by reacting with 👍 or 👎 |



Upgrades the no-op background request log from debug to warn with actionable guidance. When background jobs, scheduled tasks, or middleware (e.g., rate limiters, AMQP consumers) fire outside a test trace during replay, the log now tells users to disable these services when TUSK_DRIFT_MODE=REPLAY.
TODO: Have the setup agent detect background services and automatically configure the app to skip them during replay.