-
Notifications
You must be signed in to change notification settings - Fork 5
feat: auto-register ESM loader hooks in TuskDrift.initialize() #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+189
−171
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import { createAddHookMessageChannel } from "import-in-the-middle"; | ||
| import * as moduleModule from "module"; | ||
| import { logger } from "./utils"; | ||
| import { isCommonJS } from "./utils/runtimeDetectionUtils"; | ||
|
|
||
| const NODE_MAJOR = parseInt(process.versions.node.split(".")[0]!, 10); | ||
| const NODE_MINOR = parseInt(process.versions.node.split(".")[1]!, 10); | ||
|
|
||
| function supportsModuleRegister(): boolean { | ||
| return ( | ||
| NODE_MAJOR >= 21 || | ||
| (NODE_MAJOR === 20 && NODE_MINOR >= 6) || | ||
| (NODE_MAJOR === 18 && NODE_MINOR >= 19) | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Automatically register ESM loader hooks via `import-in-the-middle` so that | ||
| * ESM imports can be intercepted for instrumentation. | ||
| * | ||
| * In CJS mode this is a no-op because `require-in-the-middle` handles | ||
| * interception. On Node versions that lack `module.register` support | ||
| * (< 18.19, < 20.6) we log a warning and skip. | ||
| * | ||
| * https://nodejs.org/api/module.html#moduleregisterspecifier-parenturl-options | ||
| */ | ||
| export function initializeEsmLoader(): void { | ||
| if (isCommonJS()) { | ||
| return; | ||
| } | ||
|
|
||
| if (!supportsModuleRegister()) { | ||
| logger.warn( | ||
| `Node.js ${process.versions.node} does not support module.register(). ` + | ||
| `ESM loader hooks will not be registered automatically. ` + | ||
| `Upgrade to Node.js >= 18.19.0 or >= 20.6.0, or register the hooks manually.`, | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| if ((globalThis as any).__tuskDriftEsmLoaderRegistered) { | ||
| return; | ||
| } | ||
| (globalThis as any).__tuskDriftEsmLoaderRegistered = true; | ||
|
|
||
| try { | ||
| // createAddHookMessageChannel sets up a MessagePort so the main thread can | ||
| // send new hook registrations (from `new Hook(...)` calls in userland) to | ||
| // the loader thread, which runs in a separate context. | ||
| const { addHookMessagePort } = createAddHookMessageChannel(); | ||
|
|
||
| // The IITM loader hook module that intercepts ESM imports. | ||
| // Resolved relative to this SDK package (import.meta.url) so the hook | ||
| // module is found from node_modules regardless of the user's cwd. | ||
| // @ts-expect-error register exists on module in supported Node versions | ||
| moduleModule.register("import-in-the-middle/hook.mjs", import.meta.url, { | ||
| // Payload sent to the loader hook's initialize() function: | ||
| // - addHookMessagePort: the MessagePort for main↔loader communication | ||
| // - include: [] starts with an empty allowlist; only modules registered | ||
| // via new Hook([...]) on the main thread get added dynamically through | ||
| // the MessagePort, so only instrumented modules are wrapped. | ||
| data: { addHookMessagePort, include: [] }, | ||
| // Transfer (not clone) the port — a MessagePort can only be owned by one thread | ||
| transferList: [addHookMessagePort], | ||
| }); | ||
| logger.debug("ESM loader hooks registered successfully"); | ||
| } catch (error) { | ||
| logger.warn("Failed to register ESM loader hooks:", error); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 1 addition & 8 deletions
9
src/instrumentation/libraries/fetch/e2e-tests/esm-fetch/src/tdInit.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 1 addition & 8 deletions
9
src/instrumentation/libraries/firestore/e2e-tests/esm-firestore/src/tdInit.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 1 addition & 8 deletions
9
src/instrumentation/libraries/grpc/e2e-tests/esm-grpc/src/tdInit.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 1 addition & 8 deletions
9
src/instrumentation/libraries/http/e2e-tests/esm-http/src/tdInit.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.