Skip to content

Minimal devices repro#82

Closed
jy-tan wants to merge 6 commits intomainfrom
repro-devices
Closed

Minimal devices repro#82
jy-tan wants to merge 6 commits intomainfrom
repro-devices

Conversation

@jy-tan
Copy link
Contributor

@jy-tan jy-tan commented Mar 19, 2026

No description provided.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/main.yml">

<violation number="1" location=".github/workflows/main.yml:123">
P2: `continue-on-error: true` masks failures from the new repro job, so regressions in the minimal `/dev` scenario will not fail CI.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

repro-minimal-devices:
name: Repro minimal /dev (${{ matrix.runner }})
runs-on: ${{ matrix.runner }}
continue-on-error: true
Copy link

@cubic-dev-ai cubic-dev-ai bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: continue-on-error: true masks failures from the new repro job, so regressions in the minimal /dev scenario will not fail CI.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/main.yml, line 123:

<comment>`continue-on-error: true` masks failures from the new repro job, so regressions in the minimal `/dev` scenario will not fail CI.</comment>

<file context>
@@ -117,6 +117,22 @@ jobs:
+  repro-minimal-devices:
+    name: Repro minimal /dev (${{ matrix.runner }})
+    runs-on: ${{ matrix.runner }}
+    continue-on-error: true
+    timeout-minutes: 20
+    strategy:
</file context>
Suggested change
continue-on-error: true
continue-on-error: false
Fix with Cubic

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="scripts/repro_minimal_devices_ci.sh">

<violation number="1" location="scripts/repro_minimal_devices_ci.sh:31">
P2: Creating the venv under `/src` makes the repro fail on `noexec` workspaces because it later executes `${VENV_DIR}/bin/python` from the bind-mounted checkout.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@jy-tan jy-tan closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant