feat: implement retry logic for discovering persons in One Identity#636
Open
yoganandaness wants to merge 1 commit intodevelopfrom
Open
feat: implement retry logic for discovering persons in One Identity#636yoganandaness wants to merge 1 commit intodevelopfrom
yoganandaness wants to merge 1 commit intodevelopfrom
Conversation
4289a54 to
37f65a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement Retry on comparing the members from the Proposals with the Persons table in OIM
Motivation and Context
In special cases especially due to the slight latency of sync between Ping and OIM, the mapping of proposal members with the member in the Persons table does not work. Remedy on the immediate base is to add a retry logic, that tries to refetch from the Persons table
The current logic is set up with
Retries = 3
Timeout = 2s, 5s, 10s
How Has This Been Tested
Attached test case
Fixes
UOS - OIM sync
Changes
Depends on
Tests included/Docs Updated?