Skip to content

fix: standardize naming oidcSub#1386

Open
jekabs-karklins wants to merge 11 commits intodevelopfrom
fix-standardize-naming-oidcsub
Open

fix: standardize naming oidcSub#1386
jekabs-karklins wants to merge 11 commits intodevelopfrom
fix-standardize-naming-oidcsub

Conversation

@jekabs-karklins
Copy link
Contributor

@jekabs-karklins jekabs-karklins commented Feb 27, 2026

Description

This PR standardizes the naming convention of 'oidc_sub' to 'oidcSub' across the codebase.

Motivation and Context

The change is required to maintain a consistent naming convention in the codebase. This standardization will improve code readability and maintainability.

Changes

  • Renamed 'oidc_sub' to 'oidcSub' in User.ts, UserQueries.ts, BasicUserDetails.ts, basicUserInformation.graphql, and useBlankVisitRegistration.ts.
  • This change does not introduce any new functionality or modify existing behavior, it is purely a refactoring of variable names for consistency.

How Has This Been Tested?

Fixes Jira Issue

https://jira.ess.eu//browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@jekabs-karklins jekabs-karklins requested a review from a team as a code owner February 27, 2026 12:07
@jekabs-karklins jekabs-karklins requested review from simonfernandes and removed request for a team February 27, 2026 12:07
@jekabs-karklins jekabs-karklins changed the title fix: standardize oidc_sub to oidcSub across user models and queries fix: standardize naming oidc_sub to oidcSub Feb 27, 2026
@jekabs-karklins jekabs-karklins changed the title fix: standardize naming oidc_sub to oidcSub fix: standardize naming oidcSub Feb 27, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Standardizes the BasicUserDetails “OIDC subject” field naming from oidc_sub to oidcSub across the backend model/GraphQL type and the frontend GraphQL fragment + a visit-registration stub.

Changes:

  • Renamed BasicUserDetails.oidc_subBasicUserDetails.oidcSub in backend model, queries, and GraphQL resolver type.
  • Updated frontend basicUserDetails fragment to request oidcSub.
  • Updated visit registration stub user shape to use oidcSub.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
apps/frontend/src/hooks/visit/useBlankVisitRegistration.ts Updates stubbed user object to use oidcSub.
apps/frontend/src/graphql/user/fragment.basicUserInformation.graphql Renames requested field from oidc_sub to oidcSub in the fragment.
apps/backend/src/resolvers/types/BasicUserDetails.ts Renames exposed GraphQL field to oidcSub.
apps/backend/src/queries/UserQueries.ts Switches query-to-model mapping to read user.oidcSub.
apps/backend/src/models/User.ts Renames BasicUserDetails constructor property to oidcSub.

@jekabs-karklins jekabs-karklins changed the title fix: standardize naming oidcSub fix: standardize naming oidcSub Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants