-
Notifications
You must be signed in to change notification settings - Fork 14
Release: 2.24.2 #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 2.24.2 #177
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| val usercentricsVersion = "2.24.1" | ||||||
| val usercentricsVersion = "2.24.2" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: Hardcoded dependency version: embedding "2.24.2" directly in the script makes it harder to override or keep consistent across modules and CI; prefer reading the version from a project property (with a fallback) so callers can override it without editing the file. [configuration] Severity Level: Minor
Suggested change
Why it matters? ⭐The suggestion addresses a real, practical configuration shortcoming: embedding the dependency version directly in the Kotlin DSL makes it harder to override from CI or other modules and to keep versions consistent across a multi-module build. Replacing the literal with a project property fallback is a low-risk, high-value improvement that enables -P overrides (or a central versions catalog) without changing runtime behaviour when no override is provided. Note: the proposed cast in the improved_code (project.findProperty("usercentricsVersion") as String?) can be brittle if the property isn't a String; prefer project.findProperty("usercentricsVersion")?.toString() ?: "2.24.2" for a safer conversion. Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** android/build.gradle.kts
**Line:** 1:1
**Comment:**
*Configuration: Hardcoded dependency version: embedding "2.24.2" directly in the script makes it harder to override or keep consistent across modules and CI; prefer reading the version from a project property (with a fallback) so callers can override it without editing the file.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. |
||||||
| val reactNativeVersion = "+" | ||||||
|
|
||||||
| fun BooleanProperty(name: String): Boolean { | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NITPICK] The changelog now contains a new 2.24.2 entry (lines starting at 3) but also re-inserts a 2.24.0 block later (lines starting at 14), which creates a duplicate and breaks chronological ordering. Actionable steps: remove the duplicated 2.24.0 block (or merge any unique notes from it), ensure releases are ordered newest-to-oldest, and replace vague entry text like "Fix react native issues" with a short, specific summary or link to the PR/issue (e.g. "Fixed Android X behavior in X component — closes #1234").