Conversation
The role previously assumed the group for created files for user foo should be 'foo'. This assumption is false if users have a different primary group id (for instance, if all users share the same primary group), which then leads to failures because group 'foo' does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SRC-CO component has received an update for security (?) reasons:
https://gitlab.com/rsc-surf-nl/plugins/plugin-co/-/commit/dd0f206c75843cb76f17a29866f1e06aed4bab6c
Part of this update is that workspace users' primary group id's are set to the same group, i.e. a groupid corresponding to the integer id of the collaboration.
This was leading to trouble because our
runoncerole assumes that the group id for files should be the same as the username.This PR attempts to fix the issue by explicitly using the groupid passed in by
fact_regular_usersto create files.