Fix line feed character parsing in multiline value#253
Open
joyfullservice wants to merge 1 commit intoVBA-tools:masterfrom
Open
Fix line feed character parsing in multiline value#253joyfullservice wants to merge 1 commit intoVBA-tools:masterfrom
joyfullservice wants to merge 1 commit intoVBA-tools:masterfrom
Conversation
When converting JSON back to a string, line feed characters should be converted back to line feed characters, not Carriage Return & Line Feed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this has been discussed in the following issues:
As a simple matter of principle, JSON conversion should be converting, not changing the original string. A proper conversion should support a round-trip conversion back to the original value. This can be demonstrated with the following code snippet:
Replacing a line feed (
vbLf) single character, with two characters (vbCrLf) may be necessary in some applications, but this should be performed in the calling code, not embedded within the JSON conversion. In my opinion, the JSON conversion should only be performing the conversion. What goes in is what should come out. 😄On the VBA side,
vbCrLf = (vbCr & vbLf)so I don't know that we need to do anything more complicated than simply converting\ntovbLf.