Skip to content

Remove ChargingInstruction from ProvideChargingRequestsRequest#67

Open
BenjaminKowatschVector wants to merge 1 commit intomainfrom
BenjaminKowatschVector-Fix-Issue-40
Open

Remove ChargingInstruction from ProvideChargingRequestsRequest#67
BenjaminKowatschVector wants to merge 1 commit intomainfrom
BenjaminKowatschVector-Fix-Issue-40

Conversation

@BenjaminKowatschVector
Copy link
Collaborator

Removed ChargingInstruction definition from schema.
Adresses Issue #40

Removed ChargingInstruction definition from schema.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the ChargingInstruction field and its enum definition from the ProvideChargingRequestsRequest schema to address issue #40 regarding unclear usage of charging request deletion and the "TERMINATE" instruction. The repository contains JSON schema definitions for the VDV463 standard, which specifies an interface for EV charging management between presystems and load management systems.

Changes:

  • Removed ChargingInstruction enum definition with values "Normal", "Changed", and "Terminate" from schema definitions
  • Removed chargingInstruction field from the ChargingRequest object properties

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

},
"chargingRequestData": {
"$ref": "#/definitions/ChargingRequestData"
},
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal constitutes a breaking change to the API schema. The schema is marked as "VDV463 1.0.0 FINAL" (line 4), yet a field is being removed from the ChargingRequest object. This could break existing implementations that:

  1. Send chargingInstruction in their requests
  2. Have code that depends on this field for indicating Normal/Changed/Terminate states

Consider whether:

Suggested change
},
},
"chargingInstruction": {
"type": "string",
"description": "DEPRECATED in favor of alternative mechanisms for indicating NORMAL / CHANGED / TERMINATE states. Retained in VDV463 1.0.0 FINAL for backward compatibility. Allowed values: Normal, Changed, Terminate.",
"enum": [
"Normal",
"Changed",
"Terminate"
]
},

Copilot uses AI. Check for mistakes.
@BenjaminKowatschVector BenjaminKowatschVector added this to the Version 2.0.0 milestone Feb 27, 2026
@BenjaminKowatschVector BenjaminKowatschVector added the breaking change inkompatible Schemaänderung label Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change inkompatible Schemaänderung

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants