Fix _get_superclass_str to handle bare dict superclasses#21
Merged
stevevanhooser merged 2 commits intomainfrom Mar 25, 2026
Merged
Fix _get_superclass_str to handle bare dict superclasses#21stevevanhooser merged 2 commits intomainfrom
stevevanhooser merged 2 commits intomainfrom
Conversation
MATLAB's jsonencode unwraps single-element cell arrays into scalar values, so documents with a single superclass arrive as a bare dict instead of a list. This caused _get_superclass_str to return an empty string, breaking isa() queries for those documents. Normalize bare dict superclasses to single-element lists before processing, in both the top-level and document_class code paths. Fixes: Waltham-Data-Science/NDI-python#52 https://claude.ai/code/session_01W4C2GYKchUodXEVKnnM66T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_superclass_str()indoc2sql.pyto handle bare dict superclasses that arrive from MATLAB'sjsonencode(which unwraps single-element cell arrays into scalars)superclassesanddocument_class.superclassescode pathsProblem
Documents with a single superclass (e.g.
base) had theirsuperclassesfield encoded as a bare dict instead of a list by MATLAB'sjsonencode. The existing code only checked forlisttypes, so these documents got an emptymeta.superclassstring, causingisa()queries to miss them entirely. In one test dataset, 98 out of 7,221 documents were affected.Test plan
tests/test_doc2sql_superclass.pypassFixes: Waltham-Data-Science/NDI-python#52
https://claude.ai/code/session_01W4C2GYKchUodXEVKnnM66T