Implement pyraview.readFile in MATLAB and Python#14
Conversation
Added functions to read level files directly with start/stop sample indices. - MATLAB: `pyraview.readFile(filename, s0, s1)` - Python: `pyraview.read_file(filename, s0, s1)` Verified that the Dataset type considers samples as min/max pairs (planar layout). Added tests for both implementations.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Added functions to read level files directly with start/stop sample indices. - MATLAB: `pyraview.readFile(filename, s0, s1)` - Python: `pyraview.read_file(filename, s0, s1)` Both functions support reading min/max pairs from the planar file layout and handle -Inf/Inf for start/end indices. Updated documentation (API.md) to reflect the new functions and the transition to C++ implementation. Refactored MATLAB tests to use class-based unit tests. Enhanced Python tests with more comprehensive coverage and mocking.
Added functions to read level files directly with start/stop sample indices. - MATLAB: `pyraview.readFile(filename, s0, s1)` - Python: `pyraview.read_file(filename, s0, s1)` Both functions support reading min/max pairs from the planar file layout and handle -Inf/Inf for start/end indices. Updated documentation (API.md) to reflect the new functions and the transition to C++ implementation. Refactored MATLAB tests to use class-based unit tests. Enhanced Python tests with more comprehensive coverage and mocking.
Added functions to read level files directly with start/stop sample indices. - MATLAB: `pyraview.readFile(filename, s0, s1)` - Python: `pyraview.read_file(filename, s0, s1)` Both functions support reading min/max pairs from the planar file layout and handle -Inf/Inf for start/end indices. Updated documentation (API.md) to reflect the new functions and the transition to C++ implementation. Refactored MATLAB tests to use class-based unit tests in the correct package location (`+pyraview/+unittest`). Enhanced Python tests with more comprehensive coverage and mocking.
1 participant
Added
pyraview.readFile(MATLAB) andpyraview.read_file(Python) to read data from Pyraview level files given a filename and start/stop sample indices. The functions return a 3D matrix (Samples x Channels x 2) containing min and max values. The implementation correctly handles file headers, data types, and the planar data layout. Tests are included for verification.PR created automatically by Jules for task 13897329639786336155 started by @stevevanhooser