Refactor pyraview MEX and implement readFile functions#15
Refactor pyraview MEX and implement readFile functions#15stevevanhooser merged 2 commits intomainfrom
Conversation
…ctions - Renamed `src/matlab/+pyraview/pyraview_mex.c` to `src/matlab/+pyraview/pyraview.c` to compile as `pyraview.mex*`. - Added `src/matlab/+pyraview/pyraview.m` with detailed help documentation for the MEX function. - Implemented `pyraview.readFile` (MATLAB) and `pyraview.read_file` (Python) to read level files with specific start/stop indices and planar layout support. - Updated `src/matlab/build_pyraview.m` to reflect the MEX source rename. - Updated `docs/API.md` to reflect the new API structure and C++ implementation details. - Added comprehensive class-based unit tests for MATLAB (`src/matlab/tests/+pyraview/+unittest/test_readfile.m`) and Python (`src/python/tests/test_readfile.py`). - Updated existing tests to use the new `pyraview.pyraview` function name.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ctions - Renamed `src/matlab/+pyraview/pyraview_mex.c` to `src/matlab/+pyraview/pyraview.c` but reverted it back to `pyraview_mex.c` to avoid object file collision during build. Updated `build_pyraview.m` to compile it to `pyraview.mex*`. - Added `src/matlab/+pyraview/pyraview.m` with detailed help documentation for the MEX function. - Implemented `pyraview.readFile` (MATLAB) and `pyraview.read_file` (Python) to read level files with specific start/stop indices and planar layout support. - Updated `docs/API.md` to reflect the new API structure and C++ implementation details. - Added comprehensive class-based unit tests for MATLAB (`src/matlab/tests/+pyraview/+unittest/test_readfile.m`) and Python (`src/python/tests/test_readfile.py`). - Updated existing tests to use the new `pyraview.pyraview` function name.
stevevanhooser
deleted the
add-readfile-functions-13897329639786336155
branch
1 participant
This submission refactors the MATLAB MEX implementation to expose the main processing function as
pyraview.pyraviewinstead ofpyraview.pyraview_mex, providing a cleaner user experience. It also adds robust file reading functions (readFile/read_file) for both MATLAB and Python that handle the specific Pyraview binary format (planar layout, min/max pairs). Documentation and tests have been updated and expanded to professional standards.PR created automatically by Jules for task 13897329639786336155 started by @stevevanhooser