Add new OPAL-RT Asynchronous Process node-type#924
Merged
Conversation
stv0g
force-pushed
the
node-opal-async
branch
2 times, most recently
from
92c2295 to
cc0f7d3
Compare
Contributor
Author
Member
|
I didn't review, because the CI is failing. |
Contributor
Author
|
Blocked by #952 |
al3xa23
previously approved these changes
Sep 2, 2025
stv0g
force-pushed
the
node-opal-async
branch
2 times, most recently
from
93b11fb to
0ee3355
Compare
… Asynchronous process in OPAL-RT's RT-LAB Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
stv0g
force-pushed
the
node-opal-async
branch
from
0ee3355 to
3ee70a5
Compare
n-eiling
approved these changes
Nov 6, 2025
Member
n-eiling
left a comment
n-eiling
left a comment
There was a problem hiding this comment.
looks good.
Nitpick: I think ending all comment with a "." is a bit unnecessary, espc. since most of your comments aren't full sentences.
Contributor
Author
|
@n-eiling Thanks for the feedback :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new node-type for interfacing VILLASnode as an Asynchronous Process with OPAL-RT's RT-LAB software platform.
See: