Frame hook rework for frame boundary synchronization#962
Conversation
ed2f83a to
1188993
Compare
|
This PR also adds a CI job to validate the OpenAPI spec in VILLASnode rather than the documentation repo. The generated OpenAPI documentation can be viewed here: https://acs.pages.rwth-aachen.de/-/public/villas/node/-/jobs/6719350/artifacts/openapi.html#tag/config |
1188993 to
f0de2fa
Compare
|
Okay, I spent far to much time on this now :D I did some more refactoring:
|
pjungkamp
left a comment
There was a problem hiding this comment.
Just some small nitpicks for now.
n-eiling
left a comment
There was a problem hiding this comment.
LGTM
I'm getting a bit of a bad feeling that you wrap your custom smart pointer of Sample with a unique_ptr, but I guess this makes a future transition away from the manual reference counting easier.
|
I'm also not too happy with using a But there should be no reason to use a |
f0de2fa to
ee63d5d
Compare
Done. |
52e4882 to
4a8dde9
Compare
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <post@steffenvogel.de> Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
…tions Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
934a747 to
da6a478
Compare
As discussed with @pjungkamp and @fwege on Tuesday.