feat(locale): add locale management functionality#2
feat(locale): add locale management functionality#2lu-value wants to merge 1 commit intoVORPCORE:mainfrom
Conversation
|
If this PR is accepted, I will update the documentation |
|
not sure I understand what is this for each script has its own translation and those files can be imported using Import function. |
|
You're right that Import() can load translation files. But this module does more than just importing:
Currently each script implements its own translation logic. This module provides a consistent, feature-rich solution. If you think this isn't needed for vorp_lib, I understand. |
|
Yeah sorry I just dont see the need of switching language in runtime Even though you explained I cannot see a reason to add a module to load files when we have Import function that does the "same" I appreciate the effort though, thank you for making a pr. lets leave it open for now. |
Yeah, for the escrow scripts, I didn’t really consider that point |
|
no worries thank you for understanding. |
Pull request template
Important
Please complete all fields. PRs will not be merged if any fields are incomplete. Be respectful, and keep in mind that it may take some time for your PR to be reviewed.
Bear in mind refactors are up to the developers and not it's contributors after all we are the ones giving support when needed. if they are big changes I suggest you to release it under your name instead.
Type of change
Motive for This Pull Request
This PR contributes to script and server creators by allowing VORP creators to use this module so their resources can support multiple languages with a simple import.
Provide a brief explanation of why these changes are being proposed and what they aim to achieve.
It simply aims to make the life of VORP creators easier.
Explain the necessity of these changes and how they will impact the framework or its users.
This is not required; it is only a "dev" feature and has no impact on users.
Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests. Client-side and server-side tests work perfectly.
Notes if any
explanation field