refactor(app): align child store working state#273
Draft
nicko-ai wants to merge 1 commit into
Draft
Conversation
- Restore upstream session_working behavior for sessions without loaded status - Remove tests that locked in the unfinished-assistant fallback
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A - upstream-alignment refactor.
Type of change
What does this PR do?
Removes a fork-only child-store fallback that treated unfinished assistant messages as session working state before
session_statusloaded. The behavior is not listed inFORK_CHANGELOG.mdorUSER_FLOWS.md, and the matching upstreamsession_workinglogic treats missing status as idle.This restores the upstream hunk and removes the tests that only covered the fallback.
How did you verify your code works?
npx --yes bun@1.3.13 x prettier --write packages/app/src/context/global-sync/child-store.ts packages/app/src/context/global-sync/child-store.test.tsnpx --yes bun@1.3.13 test --preload ./happydom.ts ./src/context/global-sync/child-store.test.tsfrompackages/appnpx --yes bun@1.3.13 run typecheckfrompackages/appbun turbo typechecksuccessfully with Bun 1.3.13 on PATHScreenshots / recordings
Not applicable; no visual layout change.
Checklist