refactor(core): align filesystem containment helper#277
Open
nicko-ai wants to merge 2 commits into
Open
Conversation
- use upstream separator-aware contains predicate shape - cover boundary path containment cases
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Route overlap checks through the separator-aware containment helper in both core and opencode utilities. Cover child names beginning with dot-dot plus sibling and parent boundary cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A - refactor-only fork-minimality cleanup.
Type of change
What does this PR do?
Aligns the fork's AppFileSystem.contains helper with upstream's separator-aware containment predicate shape. This removes the older broad startsWith check while preserving path escape rejection.
Adds focused boundary assertions for same directory, child paths, parent escapes, siblings, and names beginning with two dots inside the parent.
How did you verify your code works?
Screenshots / recordings
N/A - no UI changes.
Checklist