Fix a bug that may cause 3d viewer to crash#16
Open
zzhmark wants to merge 5 commits intoVaa3D:masterfrom
Open
Conversation
The 3d viewer may crash on initialization with some controls' connection on between glwidgets. It can be solved by temporarily disable the connections. The controls are xcmaxslider, ycmaxslider and zcmaxslider. Note that other controls' connections are not revised, as they don't cause crash in the current setting.
linglizhang-seu
force-pushed
the
master
branch
from
3cea413 to
215c780
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3d viewer may crash during initialization with some of its controls' connections on.
It can be solved by temporarily disabling the connections.
These controls are xcmaxslider, ycmaxslider and zcmaxslider.
Other controls are not applied the revision, as they don't cause crash in the current setting.
This is tested on Win10, with Qt 4.8.6 msvc2013.