Handle empty blocks in block expressions #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any of the extents are zero (lb == up), do not update the lobound, just no-op. But return Derived& to not break the API.
We were already checking the host array volume, also check the block volume to avoid empty blocks.
Test block expressions involving zero extent/volume blocks
There was a problem hiding this comment.
Pull request overview
Improves robustness of block-expression evaluation/assignment when the selected block has zero tile-volume (empty block), and adds regression tests for these corner cases.
Changes:
- Add new unit tests covering preserve_lobound and assignments involving empty (zero-volume) blocks.
- Skip tile-move/copy-in from distributed evaluator when the target block has zero volume.
- Adjust preserve_lobound handling to avoid issues when operating on empty blocks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/expressions_impl.h | Adds regression tests for empty-block expressions and assignments. |
| src/TiledArray/expressions/expr.h | Avoids moving data into the result for zero-volume blocks. |
| src/TiledArray/expressions/blk_tsr_expr.h | Avoids calling make_tile_range-based lobound logic for empty blocks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Switches to ranges::all_of from ranges::equal to make things more obvious. Also, need to make a `p` object here, cannot use auto&& [lb, ub] directly as argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preserve_lobound()skips setting lobound when block has any zero-extent dimensioneval_tochecks for zero volume blocksAlso validated in MPQC: https://github.com/ValeevGroup/mpqc4/pull/666