fix(account-group): fix eslint and type errors in account group - #217
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dimpram101
reviewed
Jul 23, 2026
Collaborator
There was a problem hiding this comment.
kenapa di edit pakai data dari list?
kenapa ga dibuat composable untuk ambil satu data aja?
kemudian ganti onMounted jadi watch, karena akan langsung redirect jika merefresh halaman tersebut
dimpram101
requested changes
Jul 23, 2026
yusmanata
force-pushed
the
fix/account-group-eslint-errors
branch
from
July 25, 2026 14:26
3e643f9 to
092adb2
Compare
dimpram101
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memperbaiki error ESLint dan TypeScript pada form Account Group agar sepenuhnya patuh terhadap
eslint-local-rulesterbaru dan validasi tipe Vue TypeScript.Perubahan
ESLint & TypeScript Fixes
create.vue&edit.vue— Memperbaiki type mismatch pada prop komponen<Textarea>. Mengubah statis stringrows="3"menjadi number binding:rows="3"agar sesuai dengan definisi properti komponen.edit.vue— Menambahkan komponen<FieldError>pada field checkboxis_active. Meskipun schema saat ini hanya berupa boolean opsional, penambahan ini diwajibkan oleh struktur statis dari rulefertomulia/vee-field-requires-error-displayuntuk menjamin form tidak gagal menampilkan error secara sunyi (silent failure).Checklist
npx eslintpada file terdampak)Closes #216