added all the ps and other ppc extensions, need to decide on getopt for windows stuff and resolve default architecture#5176
Closed
v1X3Q0 wants to merge 63 commits into
Closed
added all the ps and other ppc extensions, need to decide on getopt for windows stuff and resolve default architecture#5176v1X3Q0 wants to merge 63 commits into
v1X3Q0 wants to merge 63 commits into
Conversation
Contributor
|
Just to put it here, I've asked the author (on slack) to remove the getopt dependency, so test_asm/test_disasm won't support Windows for now. |
Author
|
I'm mariomain, windows stuff has been removed. will still look into the other 2 bullets in a bit. |
galenbwill
suggested changes
Apr 10, 2024
Comment on lines
+2472
to
+2478
| BinaryViewType::RegisterArchitecture( | ||
| "ELF", /* name of the binary view type */ | ||
| EM_PPC, /* id (key in m_arch map) */ | ||
| BigEndian, | ||
| ppc_ps /* the architecture */ | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
Remove this -- the arch "registry" in the view type is a map, so only the last one registered would be in effect, and we don't want ppc_ps to be the default.
| bool PerformLocalDisassembly(const uint8_t *data, uint64_t addr, size_t &len, decomp_result* res, bool bigendian) | ||
| { | ||
| uint32_t local_op = 0; | ||
| uint32_t insword = 0; |
Contributor
There was a problem hiding this comment.
insword is always 0 when passed into the ppc_fcmpo/ppc_xxpermr functions
Contributor
|
i submitted a review because otherwise it wouldn't actually show my comments, but consider my review as still being "in progress" |
galenbwill
added
the
State: Blocked (Customer)
…in the first place. quantize and dequantize are in a good state
galenbwill
added a commit
that referenced
this pull request
Dec 13, 2024
galenbwill
added a commit
that referenced
this pull request
Dec 16, 2024
…t instructions, fixes/completes 64-bit instruction/register support)
Contributor
|
Squashed and merged in builds >= 4.3.6580 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the other powerpc extensions, unfortunately unix to windows differences require some external libraries.